-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skeleton of Sharding Approach #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
compilation pipeline. | ||
""" | ||
|
||
def __init__(self, circuit: Circuit) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the circuit that we are passing in here suppose to represent a block? Or is there going to be a translation step between circuit -> block? We will need to keep track of each shards that belongs to a block in the future, so I just wasn't sure that is being expressed here properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think based on the conversation this morning, that for the initial release we are having a single block so it would be 1-to-1. Hopefully I understood that. @dlucchetti interested in your thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does a circuit represent the main block's program? From my understanding, it just provides an abstraction over circuits through wires and operations, but doesn't really provide block level information. Given that we do have just a single flat block, I would assume a block would just contain one circuit compared to N arbitrary circuits if there are conditional expressions.
EXTREMELY rudimentary approach for the sharding, does not handle dependencies between shards yet, but want to get the Shard dataclass in place for Jonhas et al.